Greptile Summary

This PR fixes two major product areas: the automations pages (edit/new) and the contacts sync flow. The changes modernise the Instagram API integration (Instagram Login API vs. Facebook Graph API), add post-specific automation matching at the webhook level, introduce a graceful Inngest-fallback for contact sync, and clean up a large amount of dead code that was duplicated between server actions and `packages/core`. **Key changes:** - **Instagram API migration**: `fetchRecentInstagramMedia` and the new `fetchInstagramMediaById` now correctly hit `loginGraphUrl` (graph.instagram.com). Conversation/message endpoints are fixed to use `/me/conversations` with `platform=instagram` and the nested `messages{}` field expansion — matching Instagram Login API conventions. - **Post-picker UX**: `getInstagramPostById` is called in parallel on the edit page so a previously-selected post is always shown in the `PostPicker`, even if it falls outside the most recent 12 results. - **Contacts sync refactor**: `syncInstagramContacts` now enqueues an Inngest event and falls back to a direct, RLS-scoped sync if queueing fails. The `SyncContactsButton` replaces its Inngest realtime subscription with a simple HTTP polling loop. - **Automation matching moved to `packages/core`**: The server-action copies of `getActiveAutomations`, `checkTriggerMatch`, and `logAutomationUsage` are removed; the canonical versions in `core` are now used everywhere. `checkTriggerMatch` gains a `postId` parameter to filter comment automations by specific post. - **Live-comment webhook support**: `processCommentChanges` now also handles `live_comments` field events, the alternative `comment_id` payload shape, and a top-level `entry.field`/`entry.value` webhook format. - **Security fix in contacts queries**: `getContactsLastUpdatedAt` and `hasContactsUpdatedSince` were missing `eq(contact.userId, user.id)` filters — these are now added. **Issues found:** - **Race condition on billing limits** (`packages/core/src/contacts/sync.ts`): The neon-http fallback path skips `pg_advisory_xact_lock`, allowing concurrent syncs to potentially exceed contact billing caps. - **Silent automation miss** (`packages/core/src/automation/matching.ts`): When `postId` is `undefined` (media ID absent from webhook), all post-specific automations silently fail to fire for that event. - **Stale UI on queue timeout** (`sync-contacts-button.tsx`): The polling loop exits after 15 s without reloading the page, leaving the contact list in a stale state.

Confidence Score: 2/5

- The PR contains a billing integrity race condition and a logic path that silently suppresses automation triggers — both require fixes before merging to production. - The Instagram API and conversation fixes are solid and the code cleanup is well-structured. However, the neon-http transaction fallback removes the only concurrency guard on billing limit enforcement, and the undefined-postId guard in checkTriggerMatch can silently block all post-scoped automations when media ID is absent from a webhook payload. These are correctness bugs in revenue-critical paths. - packages/core/src/contacts/sync.ts (billing race condition) and packages/core/src/automation/matching.ts (silent automation suppression when postId is undefined)

Important Files Changed

| Filename | Overview | |----------|----------| | packages/core/src/contacts/sync.ts | Transaction fallback for neon-http driver drops the pg_advisory_xact_lock, creating a race condition where concurrent syncs can exceed billing contact limits. Core billing integrity concern. | | packages/core/src/automation/matching.ts | Adds post-scoped automation matching with a new postId parameter. The `postMatches` guard silently suppresses all post-specific automations when `postId` is undefined (unextractable from webhook), which could mask real user interactions. | | apps/app/src/components/contacts/sync-contacts-button.tsx | Replaces Inngest realtime subscription polling with a simple HTTP polling loop. Removes RealtimeSyncWatcher and realtime state. Missing reload on queue timeout leaves contacts stale. | | packages/instagram/src/auth.ts | Switches media endpoint from facebookGraphUrl to loginGraphUrl, removes caption from fields, adds new fetchInstagramMediaById function. URL and scope changes look correct for Instagram Login API. | | packages/instagram/src/conversations.ts | Fixes conversation and message fetch patterns: always uses /me/conversations, adds platform=instagram param, and corrects message extraction from the nested messages.data structure. Looks correct. | | packages/core/src/workflows/instagram-webhook.ts | Adds live_comments webhook support, alternative comment_id field, and top-level entry field/value fallback format. The postId is now forwarded to checkTriggerMatch to enable post-specific automation filtering. | | apps/app/src/actions/contacts.ts | Refactors syncInstagramContacts to queue via Inngest with a direct-sync fallback. Fallback correctly uses getRLSDb() scoped client. Adds missing userId filter to getContactsLastUpdatedAt and hasContactsUpdatedSince queries — important security fix. |

Sequence Diagram

```mermaid sequenceDiagram participant Browser participant SyncBtn as SyncContactsButton participant ServerAction as contacts.ts (server action) participant Inngest participant CoreSync as core/contacts/sync.ts participant DB as Postgres (RLS) Browser->>SyncBtn: click Sync SyncBtn->>ServerAction: syncInstagramContacts(fullSync) ServerAction->>Inngest: inngest.send("contacts/sync") alt Inngest available Inngest-->>ServerAction: accepted ServerAction-->>SyncBtn: { success: true, queued: true } loop Poll every 1.2s (max 15s) SyncBtn->>ServerAction: hasContactsUpdatedSince(before) ServerAction->>DB: SELECT id WHERE updatedAt > before DB-->>ServerAction: rows ServerAction-->>SyncBtn: { updated } alt updated SyncBtn->>Browser: toast + reload end end SyncBtn->>Browser: toast "queued, check back" else Inngest unavailable Inngest-->>ServerAction: throw ServerAction->>CoreSync: fetchAndStoreInstagramContactsCore(dbClient, userId, billing) CoreSync->>DB: transaction → pg_advisory_xact_lock Note over CoreSync,DB: Falls back to no-lock path if neon-http CoreSync->>DB: upsert contacts (billing-gated) CoreSync-->>ServerAction: contacts[] ServerAction-->>SyncBtn: { success: true, count, queued: false } SyncBtn->>Browser: toast + reload end ```

Prompt To Fix All With AI

`````markdown This is a comment left during a code review. Path: packages/core/src/contacts/sync.ts Line: 559-573 Comment: **Billing limit race condition when neon-http fallback triggers** When `params.dbClient.transaction(...)` throws `"No transactions support in neon-http driver"`, the catch block falls back to `storeChunk(params.dbClient)` — without `{ acquireLock: true }`. This means the `pg_advisory_xact_lock` is never acquired, and two concurrent syncs for the same user can both: 1. Read the same contact count (under the billing cap) 2. Both calculate remaining slots as positive 3. Both proceed to insert — collectively exceeding `maxContactsTotal` / `maxNewContactsPerMonth` Since the lock is a `pg_advisory_xact_lock` (transaction-scoped), it cannot be used outside a transaction, so a lock-free path is inherently needed for the neon-http driver. However, the risk of a billing bypass should be explicitly acknowledged, and a best-effort mitigation (e.g., re-checking counts after the insert and rolling back over-inserts, or serialising the fallback path at the application level) should be considered. How can I resolve this? If you propose a fix, please make it concise. --- This is a comment left during a code review. Path: packages/core/src/automation/matching.ts Line: 61-68 Comment: **Post-specific automations silently skip when `postId` is undefined** `postMatches` is evaluated as: ``` scope !== "comment" || !postIdsByAutomationId.has(automationRecord.id) || postIdsByAutomationId.get(automationRecord.id) === postId ``` When `scope === "comment"`, the automation has a specific post configured (`postIdsByAutomationId.has(...)` is `true`), and `postId` is `undefined` (i.e., `mediaId` could not be extracted from the webhook because `value.media?.id` and `value.media?.original_media_id` were both absent), the expression evaluates to `false` — the automation silently fails to fire even though the trigger word matched. The `mediaId` extraction in `instagram-webhook.ts` currently falls through to `undefined` whenever the `media` field is missing from the webhook payload. This can happen for certain Instagram comment webhook variants. In that scenario **every** post-scoped automation is blocked. Consider treating `postId === undefined` as "media unknown" and still firing the automation (optionally with a flag), or at minimum logging a warning so the failure can be diagnosed: ```ts const postMatches = scope !== "comment" || postId == null || // unknown media → allow through !postIdsByAutomationId.has(automationRecord.id) || postIdsByAutomationId.get(automationRecord.id) === postId; ``` How can I resolve this? If you propose a fix, please make it concise. --- This is a comment left during a code review. Path: apps/app/src/components/contacts/sync-contacts-button.tsx Line: 67-85 Comment: **Page not refreshed when queued sync times out — user left with stale contacts** When `result.queued && before`, the polling loop runs for `MAX_SYNC_STATUS_WAIT_MS` (15 s). If the Inngest job does complete within that window it correctly calls `window.location.reload()`. However, if the timeout is reached first, the function only shows a toast and returns — it never reloads. The user's contact list stays stale even though the Inngest job may have just finished milliseconds after the timeout. Consider triggering a reload on timeout as well, to surface contacts the background job may already have written: ```ts toast.success("Sync queued. Inngest accepted the event; updates will appear shortly."); window.location.reload(); // <-- add this return; ``` If an immediate reload is undesirable (the job may not have finished), the toast message should clearly guide the user to manually refresh. How can I resolve this? If you propose a fix, please make it concise. `````

_{Last reviewed commit: 545b76c} > Greptile also left **3 inline comments** on this PR.